blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

Update continuous toolbox plugin for flyout API changes

Open gonfunko opened this issue 1 year ago • 1 comments

Check for duplicates

  • [X] I have searched for similar issues before opening a new one.

Component

Continuous Toolbox plugin

Description

The flyout API is changing in Blockly v12 (see https://github.com/google/blockly/pull/8601), and the continuous toolbox plugin will need to be updated for compatibility. Most of the needed changes have already been made in https://github.com/gonfunko/scratch-blocks/pull/209#pullrequestreview-2352707135 and will just need to be backported, but we'll need to coordinate merging/publishing to coincide with the v12 release.

Reproduction steps

No response

Stack trace

No response

Screenshots

No response

gonfunko avatar Oct 07 '24 19:10 gonfunko

ContinuousToolbox.getInitialFlyoutContents_() should also be refactored to allow subclasses to make changes. It should probably call a conversion function for each item, which subclasses could override to support additional types of flyout items or just delegate to super.

gonfunko avatar Oct 07 '24 22:10 gonfunko