blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

`npm run test:ghpages:beta` doesn't work for hoisting

Open maribethb opened this issue 7 months ago • 2 comments

Check for duplicates

  • [X] I have searched for similar issues before opening a new one.

Component

blockly-samples infrastructure

Description

We recently changed how we structure the dependencies in samples to use hoisting so we eliminate the "two blockly problem"

However running npm run test:ghpages:beta will try to install blockly@beta inside every plugin which is now wrong. That's fine for examples where we're not using hoisting. For samples it needs to install blockly@beta at the root of samples. but there might be problems if the plugins say they require a version of blockly that isn't compatible with the beta.

Don't run this command until this is fixed

Reproduction steps

Stack trace

No response

Screenshots

No response

maribethb avatar Jun 28 '24 01:06 maribethb