blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

remove references to `Blockly.FieldColour` from keyboard-navigation

Open maribethb opened this issue 8 months ago • 0 comments

Check for duplicates

  • [X] I have searched for similar issues before opening a new one.

Component

keyboard-navigation

Description

The keyboard navigation attempts to patch Blockly.FieldColour. That field no longer exists, so even referencing it causes webpack warnings.

To fix

  1. In navigation_controller.ts, remove the lines that attempt to add or remove the onShortcut handler to Blockly.FieldColour.
  2. In the same file, remove the now-unused fieldColourHandler function.

If you'd like to work on this issue see also our contributing docs and comment here saying that you'd like to work on this.

Reproduction steps

  1. Run npm run build in plugins/keyboard-navigation
  2. Notice warnings about how Blockly.FieldColour doesn't exist

Stack trace

No response

Screenshots

No response

maribethb avatar May 31 '24 18:05 maribethb