blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

Content-highlight doesn't update for workspace comment move events

Open BeksOmega opened this issue 1 year ago • 1 comments

Check for duplicates

  • [X] I have searched for similar issues before opening a new one.

Component

workspace-content-highlight

Description

If you move workspace comments or add them to the workspace, they don't update the content highlight. However if you move a block, the content highlight updates to highlight everything including the comments.

Reproduction steps

  1. Load the following JSON into the workspace.
{
  "workspaceComments": [
    {
      "height": 100,
      "width": 120,
      "id": "o`-uR}#Q,qg#1LUorXg5",
      "x": 131.890625,
      "y": 326,
      "text": "Say something..."
    },
    {
      "height": 100,
      "width": 120,
      "id": "*CHb18}Td!%xT~MTvk!N",
      "x": 327.5572814941406,
      "y": 698.3333129882812,
      "text": "Say something..."
    }
  ],
  "blocks": {
    "languageVersion": 0,
    "blocks": [
      {
        "type": "controls_if",
        "id": "0NAT)tSk}AALHd#HIB%x",
        "x": 213,
        "y": 162
      }
    ]
  }
}
  1. Move the comments around.
  2. Observe how the highlight does not update.

Stack trace

No response

Screenshots

No response

Additional Info

This has to be tested against v11.

BeksOmega avatar Apr 19 '24 16:04 BeksOmega

Next step: disentangle @johnnesky's existing (and approved) draft PR and merge it.

rachel-fenichel avatar Nov 21 '25 23:11 rachel-fenichel