blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

Migration script readme gives invalid order of arguments

Open BeksOmega opened this issue 1 year ago • 4 comments

Check for duplicates

  • [X] I have searched for similar issues before opening a new one.

Component

@blockly/migrate

Description

The readme for the migration plugin suggests the following format for running the script:

npx @blockly/migrate rename --from 6 --in-place ./path/to/my/files*
npx @blockly/migrate rename --from 6 --to 7 --in-place ./path/to/my/files*

This is invalid because --in-place actually takes a file parameter (a suffix to add to the output). So this is running on no files.

It should look like:

npx @blockly/migrate rename ./path/to/my/files* --from 6 --in-place 
npx @blockly/migrate rename ./path/to/my/files* --from 6 --to 7 --in-place

The help options in the plugin may need to be updated as well. But fixing the readme is low lift.

Reproduction steps

Stack trace

No response

Screenshots

No response

BeksOmega avatar Jan 26 '24 16:01 BeksOmega

Hey @BeksOmega @maribethb,

I would like to work on this issue. Can you please assign this to me?

jenish-thapa avatar Aug 10 '24 13:08 jenish-thapa

Go for it @jenish-thapa =) Let me know if you have any questions!

BeksOmega avatar Aug 12 '24 20:08 BeksOmega

@rachel-fenichel, you asked me to take this issue, so please review once.

viky-01 avatar May 22 '25 19:05 viky-01

When you open a PR, it is assigned to a team member automatically. There's no need to tag us an additional time. Thanks for working on this and for your patience as we review your code!

maribethb avatar May 22 '25 19:05 maribethb