Enable strict mode for block-shareable-procedures
Check for duplicates
- [X] I have searched for similar issues before opening a new one.
Component
block-shareable-procedures
Problem
No response
Request
The block-shareable-procedures plugin does not have "strict mode" enabled for TypeScript. We should enable it to have better type checking for our plugins, but doing so may show some TypeScript errors that need to be fixed first.
This would be a good first issue for anyone experienced with working in TypeScript. You may need to adjust types, add checks for null or undefined, or make other fixes. If you have questions, feel free to ask here! In general, the team prefers avoiding casts and using ! to coerce non-null types, and instead adding appropriate checks.
To work on this issue:
- Run
npm installat the root of Blockly samples to set up dependencies. - Navigate to the plugin's directory
- Change
strict: falsetostrict: truein the plugin's tsconfig.json - Run
npm run buildand see if there are any TypeScript errors. - Resolve any TypeScript errors, if present. If not, then we got lucky and accidentally wrote strict code! Yay!
- Run
npm run buildagain to make sure there are no TypeScript errors. - Run
npm run startand play with the plugin in the playground to make sure the plugin still behaves as expected. - Run
npm run testto run any automated tests. - Run
npm run lintto make sure there are no formatting errors. - Open a PR with your changes!
Alternatives considered
No response
Additional context
No response
Hi @maribethb. I'd like to work on this issue.
@Amir-Helali Go for it =) If you have any questions let us know!