blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

Update minimum node engine value in plugins and template

Open maribethb opened this issue 2 years ago • 4 comments

The create-package templates create every plugin to say minimum node engine is 8; I think this needs to be updated though I'm actually not sure as of this writing what the minimum node version of Blockly is. Hopefully it's higher than 8 though...

We should find this value, update all existing plugins, and update the templates

maribethb avatar Jan 26 '23 21:01 maribethb

Hopefully it's higher than 8 though...

Why would we hope that? Ideally everything would work fine in the oldest versions of node (though I doubt that is the case!). Do we know for sure that there is an incompatibility with a version >= 8?

On the other hand, we just say the minimum version is 14, since (at least in core) that is the oldest we currently test.

cpcallen avatar Jan 30 '23 19:01 cpcallen

Ok, hopefully was the wrong word. But I am pretty sure we had to bump the minimum node version of Blockly, though that may have only been for test reasons.

We don't even specify this value in core blockly's package.json. I think we probably shouldn't specify it for every single plugin unless the plugin has an actual known problem or dependency on a specific node engine. If Blockly itself has a minimum version, we should document it there and not in the plugins. So I think we should just remove this value from the templates and from all the plugins as none of them (to my knowledge) actually require a specific node version.

maribethb avatar Jan 31 '23 18:01 maribethb

So I think we should just remove this value from the templates and from all the plugins as none of them (to my knowledge) actually require a specific node version.

I concur.

cpcallen avatar Feb 01 '23 14:02 cpcallen

minimum node version for webpack 5 which dev-script uses is 10.13 so IMO it should at least that. But Node 16 is out of maintenance so I would prefer if we could just support node >= 18..

alicialics avatar Sep 26 '23 21:09 alicialics