blockly-samples icon indicating copy to clipboard operation
blockly-samples copied to clipboard

cross-tab-copy-paste can copy a block from inside the bubble to outside the bubble.

Open Taikono-Himazin opened this issue 3 years ago • 1 comments

cross-tab-copy-paste can copy a block from inside the bubble to outside the bubble. image

image

This will cause an error when generating the code. Right-clicking is prohibited in the bubble, but you can copy using the shortcut key.

Taikono-Himazin avatar Jun 21 '22 07:06 Taikono-Himazin

Fixing this issue has a few steps:

  1. Reproduce the issue using the steps outlined in the "To Reproduce" section. Once you can reproduce the bad behavior, you can test if your changes fixed it.
  2. Modify the code in plugins/cross-tab-copy-paste/src/index.js so that the precondition function of the copy shortcut returns false if the block is in a mutator workspace.
  3. Run the reproduction steps again, and verify that the blocks cannot be copied from inside the mutator to outside of the mutator.
  4. Open your PR and resolve any PR comments.

After your PR is accepted, a Blockly team member will have to publish the GitHub Pages site, and then you'll be able to see your change live!

BeksOmega avatar Aug 04 '22 23:08 BeksOmega

Is this task still open? If so, can I pick this up?

debaraj-barua avatar Sep 22 '22 18:09 debaraj-barua

Yup! @debaraj-barua I just assigned you : )

alschmiedt avatar Sep 23 '22 00:09 alschmiedt

@debaraj-barua Thanks for the fix! I can't wait for the release of this.

Taikono-Himazin avatar Sep 29 '22 06:09 Taikono-Himazin