bindiff icon indicating copy to clipboard operation
bindiff copied to clipboard

Fix names in Primary Unmatched window

Open Muirey03 opened this issue 1 year ago • 1 comments

In a C program, all the functions in the Unmatched Primary window are named sub_XXX. This is because the real name is stored in name and demangled_name is set to "" while GetUnmatchedDescription only checks if it is nullptr.

This pull request fixes this issue by checking for "" as well as nullptr.

Muirey03 avatar Aug 02 '24 14:08 Muirey03

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 02 '24 14:08 google-cla[bot]