bigwheels
bigwheels copied to clipboard
google
Add GLTF Scene Loader
Using the library cgltf, implements a GLTF scene laoder for BigWheels's scene graph.
Also, defines an interface for generic scene loaders, in case we come up with other ways of storing and loading scenes.
This code now being orphaned, and quite self contained (we don't break bigwheels by bringing it in), I would be fine to merge this as-is (minus the small fixes), and iterate from there, as long as this compiled on all 3 platforms.
This code now being orphaned, and quite self contained (we don't break bigwheels by bringing it in), I would be fine to merge this as-is (minus the small fixes), and iterate from there, as long as this compiled on all 3 platforms.
@Keenuts ehh - I don't mind trying to address the comments directly in this PR, that way nothing slips through unaddressed. I don't think this PR is needed too immediately
This code now being orphaned, and quite self contained (we don't break bigwheels by bringing it in), I would be fine to merge this as-is (minus the small fixes), and iterate from there, as long as this compiled on all 3 platforms.
@Keenuts ehh - I don't mind trying to address the comments directly in this PR, that way nothing slips through unaddressed. I don't think this PR is needed too immediately
Sure, we can address the open comments. But since this is a 4K Loc PR adding a new API with 0 tests, I think we'll miss many bugs anyway. So as long as nothing relies on this before it's proven to work, I'm OK merging this.
@Keenuts @anishmgoyal any objections to merging this as is and addressing the outstanding comments in a follow up? This way @footballhead will be able to make progress on GLTF work
@Keenuts @anishmgoyal any objections to merging this as is and addressing the outstanding comments in a follow up? This way @footballhead will be able to make progress on GLTF work
Sorry - I've been distracted with other things. Merging this sounds good to me