autocxx icon indicating copy to clipboard operation
autocxx copied to clipboard

Published 20 hours ago • verified publisher icon google

added integration test for virtual method inheritance

Open johnperry-math opened this issue 2 years ago • 4 comments

Adds an integration test to address Issue #774

johnperry-math avatar Feb 08 '22 15:02 johnperry-math

@johnperry-math I'd like to land this test now with an extra attribute:

#[ignore] // https://github.com/google/autocxx/issues/774

to avoid future merge conflicts, like the one which just occurred. Please could you update the PR to add that?

adetaylor avatar Feb 14 '22 21:02 adetaylor

Sorry it took so long. I believe I have made the change successfully and redid the pull request. I didn't mean to wait so long; again, sorry about that.

johnperry-math avatar Apr 21 '22 03:04 johnperry-math

Thanks, but I fear you added the attribute to the wrong test!

adetaylor avatar Apr 21 '22 23:04 adetaylor

I'm so sorry. I dawdled so long that I had to spend a lot of time merging to reconcile our branches (e.g., the old tests.rs was gone) so I just searched on test_virtual and it didn't occur to me that there might be more than 1 function that started with that phrase. I've fixed it now (I even compared commands with the original issue to be sure).

johnperry-math avatar Apr 22 '22 00:04 johnperry-math