arm-gic icon indicating copy to clipboard operation
arm-gic copied to clipboard

Should Interrupt Routing Register be 64bit?

Open kuqin12 opened this issue 1 year ago • 0 comments

The current definition of GICD is defining irouter as an array of u64: https://github.com/google/arm-gic/blob/40ceaf3fcdf7ebd82fe1a62f34a85e991916f2cd/src/gicv3/registers.rs#L124.

However, this is in conflict of the implementation in EDK2: https://github.com/tianocore/edk2/commit/1bb76029eff4993b31dbbb19acd86d1c8ad4933f.

Could you please confirm whether the definition in this structure is incorrect or the EDK2 implementation is wrong?

Also, is it possible to make this "register" module public? The driver exposed decent amount of methods to work with GIC, but it is not comprehensive. Given GICD and GICR definition is large and complicated, it seems redundant to duplicate the definitions elsewhere if this can be treated as a center source of definitions.

kuqin12 avatar Sep 26 '24 21:09 kuqin12