argh
argh copied to clipboard
google
Add -h as a short alias for --help
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sadmac7000 I submitted this pull request in 2021. After these years, is it worth making this simple change configurable? If I was the maintainer, I would have merged it and bumped up the major version.
argh exists specifically to implement the Fuchsia command line argument guidelines. Breaking behaviors outside of those guidelines need more than just a major revision bump. They need an update to the guidelines or to be disabled by default.
@sadmac7000 Where is the Fuschia documentation so that I can make the same pull request for that?
The guidelines are documented in Google's git hosting here: https://fuchsia.googlesource.com/fuchsia/+/refs/heads/main/docs/development/api/cli.md
@sadmac7000 Reimplemented the help trigger logic to make it configurable through attributes.
@sadmac7000 You're welcome. The branch is already rebased. I noticed the GitHub UI can be outdated, so maybe refresh your page.
It's still claiming the branch cannot be rebased due to conflicts and won't let me merge. I refreshed a few times. I'll look again later in case it's a transient error.
I had to pull it down and manually rearrange it. In the future, please rebase your changes when you need to update rather than merging in upstream. It confuses github.