android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Integration tests for Resource sync

Open deepankarb opened this issue 3 years ago • 3 comments

thanks @deepankarb :)

same in this PR: what tests should we have had that should have failed for this code change?

@jingtang10 Individually both resource sync and local change management work fine. Integration tests for resource sync are missing :)

Originally posted by @deepankarb in https://github.com/google/android-fhir/issues/302#issuecomment-795363609

We need to implement integration test for Resource sync.

deepankarb avatar Mar 22 '21 10:03 deepankarb

So by integration test here, we mean instrumentation test which mean using real device? I can push a fix for it in which we'll be verifying if the sync actually takes place via observing the UI

s-ayush2903 avatar Mar 22 '21 10:03 s-ayush2903

thanks @deepankarb :) same in this PR: what tests should we have had that should have failed for this code change?

@jingtang10 Individually both resource sync and local change management work fine. Integration tests for resource sync are missing :)

Originally posted by @deepankarb in #302 (comment)

We need to implement integration test for Resource sync.

@jingtang10 @deepankarb I kind of am working on this (issue number: #380 and #381) If you don't mind can I take this up ? I will be definitely making a PR ASAP.

Ana2k avatar Mar 23 '21 18:03 Ana2k

Not in UI - since the SDK doesn't have any. I think something like the medium tests mentioned here: https://developer.android.com/training/testing/fundamentals#medium-tests

From the above link:

Tests in your app's repository layer, which verify that your different data sources and data access objects (DAOs) interact as expected.

deepankarb avatar Mar 24 '21 04:03 deepankarb