android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Ordering of patches with cycles during upload

Open aditya-07 opened this issue 10 months ago • 1 comments

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2500

Description

  1. Find subgraphs (weakly connected) of Resources with cycles in them .
  2. Pack the subgraphs in Bundles such that a single subgraph is not split between two Bundles (as it may cause server error).
  3. Order the remaining resources and add them to the Bundle (in remaining space of or new Bundles) .

Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • [ ] I have read and acknowledged the Code of conduct.
  • [ ] I have read the Contributing page.
  • [ ] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • [ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • [ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • [ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • [ ] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

aditya-07 avatar Apr 23 '24 06:04 aditya-07

Is this ready for review ?

MJ1998 avatar May 01 '24 16:05 MJ1998

It's the Tarjan's Algorithm: https://www.geeksforgeeks.org/tarjan-algorithm-find-strongly-connected-components/

MJ1998 avatar May 17 '24 06:05 MJ1998