android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Date Picker Constraint Not Enforced on 'Ok' Button Click.

Open AdityaKBhadragond14 opened this issue 10 months ago • 6 comments

Describe the bug In the date picker if there is some constraint which does not allow to select the current date and the user still clicks on "OK" button without selecting any date it still selects the current date as the answer as it is the default to it.

Screen_recording_20240404_153456.webm

Component SDC Gallery app

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior There can be two approaches to solving this:

  1. Disable the "OK" button if the date selected is invalid enable only when the selected date is valid.
  2. Set the default date to the minimum valid date. This way we can reduce the number of clicks the user has to do in order to select a valid date.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Pixel4a emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

Would you like to work on the issue? Yes.

AdityaKBhadragond14 avatar Apr 04 '24 10:04 AdityaKBhadragond14

@MJ1998 Please check if I have missed anything to add here. Thanks.

AdityaKBhadragond14 avatar Apr 04 '24 10:04 AdityaKBhadragond14

I would say disable the calendar popup itself when there is no valid date possible + show an error that there is no valid date. Thanks Aditya.

MJ1998 avatar Apr 04 '24 17:04 MJ1998

I would say disable the calendar popup itself when there is no valid date possible + show an error that there is no valid date. Thanks Aditya.

Okay, this will be for the case when the min and max dates are overlapping, right? Also I think going with 2nd solution to solve this issue would be better as you had suggested because this will avoid increasing the number of clicks.

AdityaKBhadragond14 avatar Apr 06 '24 03:04 AdityaKBhadragond14

Yes right. I suggested this I would say disable the calendar popup itself when there is no valid date possible + show an error that there is no valid date. only when max < min. The other solution of yours seems correct!

MJ1998 avatar Apr 08 '24 07:04 MJ1998

Okay got it.

AdityaKBhadragond14 avatar Apr 10 '24 11:04 AdityaKBhadragond14

I would say disable the calendar popup itself when there is no valid date possible + show an error that there is no valid date. Thanks Aditya.

personally not too keen on this - it's such a niche case and would probably mean the questionnaire author needs to do something about it - if the behaviour of our widget is consistent (i guess you would not be able to input any date ultimately) i'm happy for us to not handle this case additionally.

jingtang10 avatar Jun 04 '24 10:06 jingtang10