android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Update the clinical reasoning version to v3.1.0

Open dubdabasoduba opened this issue 11 months ago • 8 comments

Is your feature request related to a problem? Please describe.

  • The clinical reasoning library was updated to add the ability to generate unique serialized IDs for resources on the $apply results. This makes it easier to persist these resources to the DB.
  • Here is a ticket for the same https://github.com/cqframework/clinical-reasoning/issues/420

Describe the solution you'd like

  • We need to update this version to allow the testing of this fix on the SDK-implementing apps

Would you like to work on the issue? Please state if this issue should be assigned to you or who you think could help to solve this issue.

dubdabasoduba avatar Mar 08 '24 08:03 dubdabasoduba

@jingtang10 @aditya-07

santosh-pingle avatar Mar 11 '24 06:03 santosh-pingle

looks good @dubdabasoduba do you have time to do this?

jingtang10 avatar Mar 13 '24 18:03 jingtang10

No we don't have capacity to work on this

pld avatar Mar 13 '24 23:03 pld

Hi, I updated the clinical-reasoning version from 3.0.0-PRE9-SNAPSHOT to the latest 3.2.0 locally but after upgradation, got the following errors on some files.

cc: @jingtang10 @dubdabasoduba @pld @MJ1998 @santosh-pingle

owais-vd avatar Mar 26 '24 09:03 owais-vd

Hi, I updated the clinical-reasoning version from 3.0.0-PRE9-SNAPSHOT to the latest 3.2.0 locally but after upgradation, got the following errors on some files.

cc: @jingtang10 @dubdabasoduba @pld @MJ1998 @santosh-pingle

@vitorpamplona is this something you can support on?

dubdabasoduba avatar Mar 27 '24 10:03 dubdabasoduba

Comment from Vitor:-

Just make sure all dependencies align. You might need to update HAPI's base version to whichever version the clinical reasoning uses.

MJ1998 avatar Apr 07 '24 08:04 MJ1998

Updating PlanDefinitionProcessor and evaluateMeasure is easy.

To update apply APIs I think it will require adding knowledge manager(KM) as a dependency in workflow. Then we will have repository implementations from KM.

For IgLayoutMode and ResourceCategory this is the relevant PR in the CQF library repo where these were removed. Can you figure out how to transition. They mention something like flat structure.

applyR5 will be updated similarly like the other apply methods in FhirOperator, right ?

@dubdabasoduba @aditya-07

MJ1998 avatar Apr 09 '24 07:04 MJ1998

My bad, I got confused between this and another issue in KM. We don't need to add KM as a dependency.

This is how you can resolve the apply funciton:-

return planDefinitionProcessor.apply(
      /* planDefinition = */ Eithers.forMiddle3 (IdType("PlanDefinition", planDefinitionId)),
      /* subject = */ subject,
      /* encounter = */ encounterId,
      /* practitioner = */ null,
      /* organization = */ null,
      /* userType = */ null,
      /* userLanguage = */ null,
      /* userTaskContext = */ null,
      /* setting = */ null,
      /* settingContext = */ null,
      /* parameters = */ null,
      /* useServerData = */ null,
      /* bundle = */ null,
      /* prefetchData = */ null,
      libraryProcessor,
    ) as IBaseResource

MJ1998 avatar Apr 15 '24 13:04 MJ1998

My bad, I got confused between this and another issue in KM. We don't need to add KM as a dependency.

This is how you can resolve the apply funciton:-

return planDefinitionProcessor.apply(
      /* planDefinition = */ Eithers.forMiddle3 (IdType("PlanDefinition", planDefinitionId)),
      /* subject = */ subject,
      /* encounter = */ encounterId,
      /* practitioner = */ null,
      /* organization = */ null,
      /* userType = */ null,
      /* userLanguage = */ null,
      /* userTaskContext = */ null,
      /* setting = */ null,
      /* settingContext = */ null,
      /* parameters = */ null,
      /* useServerData = */ null,
      /* bundle = */ null,
      /* prefetchData = */ null,
      libraryProcessor,
    ) as IBaseResource

This makes sense. Looking forward to testing the PR

dubdabasoduba avatar Apr 16 '24 08:04 dubdabasoduba

Closing this as fixed by #2637

jingtang10 avatar Jul 26 '24 13:07 jingtang10

Noting that we're now using v3.8.0. Pls see our version catalog: https://github.com/google/android-fhir/blob/9bd76c8358a534e0e403e65b81921e1a301f59e0/gradle/libs.versions.toml#L29

jingtang10 avatar Jul 26 '24 13:07 jingtang10