android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

FhirSyncDbInteractor

Open MJ1998 opened this issue 4 months ago • 0 comments

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2456 #2363 #2386

Introducing FhirSyncDbInteractor interface which acts as an abstract layer over database operations during sync. This is used by the FhirSynchronizer.

Now the synchronizer returns a Flow<SyncJobStatus> and is neatly invoked like following:-

val terminalSyncJobStatus =
    FhirSynchronizer(
      fhirSyncDbInteractor = fhirSyncDbInteractor,
      uploader = uploader,
      downloader = downloader,
    )
    .synchronize()
    .onEach { setProgress(buildWorkData(it)) }
    .first { it is SyncJobStatus.Failed || it is SyncJobStatus.Succeeded }

Tests not fixed yet

Description Clear and concise code change description.

Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • [ ] I have read and acknowledged the Code of conduct.
  • [ ] I have read the Contributing page.
  • [ ] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • [ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • [ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • [ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • [ ] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

MJ1998 avatar Feb 26 '24 15:02 MJ1998