android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Published 20 hours ago • verified publisher icon google

Add Launch and Submission Timestamps to QR

Open hamza-vd opened this issue 1 year ago • 7 comments

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2372

Description PR adds QuestionnaireItemComponent and QuestionnaireResponseItemComponent for form launch and submission timestamps

Alternative(s) considered N/A

Type Feature

Screenshots (if applicable)

Checklist

  • [x] I have read and acknowledged the Code of conduct.
  • [x] I have read the Contributing page.
  • [x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • [x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • [x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • [ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • [x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

cc: @f-odhiambo @qiarie

hamza-vd avatar Jan 04 '24 08:01 hamza-vd

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 04 '24 08:01 google-cla[bot]

@hamza-vd Please update the branch to latest.

aditya-07 avatar Jan 10 '24 08:01 aditya-07

@aditya-07 this is done

hamza-vd avatar Jan 10 '24 10:01 hamza-vd

I think we should not implicitly do this for all Questionnaires as it might be undesirable to receive unexpected items in QuestionnaireResponse.

We should consider adding the flag to either DataCaptureConfig or via QuestionnaireFragment.args!

I don't think we should use items at all for this type of metadata. And if we use extension we can avoid adding additional configs too.

jingtang10 avatar Feb 06 '24 09:02 jingtang10

Any update here?

jingtang10 avatar Feb 19 '24 10:02 jingtang10

@jingtang10 As suggested there will be a change in the implementation. I will implement the following changes.

  1. The authored field will be used as a submission timestamp.
  2. The launch-timestamp will be added as an extension to the QuestionnaireResponse

hamza-vd avatar Feb 21 '24 12:02 hamza-vd

thanks for creating this discussion @hamza-vd: https://chat.fhir.org/#narrow/stream/179255-questionnaire/topic/Ability.20to.20Capture.20Questionnaire.20Launch.20and.20Submit.20Timestamp

jingtang10 avatar Mar 27 '24 16:03 jingtang10