android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

[SDC] Move help button location to after question title

Open shelaghm opened this issue 1 year ago • 4 comments

Problem Current help button is located after instructions field, which looks awkward if there's no instructions text

Describe the solution you'd like EmCare implementation moved the help button to be located after the question title.

Describe alternatives you've considered Could make this configurable, but don't think it is necessary at this time.

Additional context EmCare commit https://github.com/google/android-fhir/commit/c130243616a9c355e8e3b5a9f25673e817769336

Screenshot Screenshot 2023-04-12 at 14 47 25

cc @santosh-pingle @kunjan8794 @khyativyasargus @jingtang10

shelaghm avatar Apr 12 '23 21:04 shelaghm

@kunjan8794 @khyativyasargus I see corresponding commit of your repository https://github.com/google/android-fhir/commit/c130243616a9c355e8e3b5a9f25673e817769336 Are you going to create PR corresponding to main repository android fhir sdk? Or you want me to look into it? cc @jingtang10

santosh-pingle avatar Apr 17 '23 05:04 santosh-pingle

@santosh-pingle Sure. We will create PR for this in main repository.

khyativyasargus avatar Apr 18 '23 07:04 khyativyasargus

@khyativyasargus thanks!, is there any approximate date by which we can expect the pull request?

santosh-pingle avatar Apr 20 '23 06:04 santosh-pingle

@santosh-pingle Yes, You can expect all PRs done by 24th April, Monday. Let me know if it's needed before that. Thanks!

khyativyasargus avatar Apr 20 '23 07:04 khyativyasargus