android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Published 20 hours ago • verified publisher icon google

Add integration tests for the QuestionnaireFragment in the datacapture module

Open jingtang10 opened this issue 4 years ago • 20 comments

https://github.com/google/android-fhir/issues/184#issue-794091744

jingtang10 avatar Jan 26 '21 09:01 jingtang10

Are we going to follow the robot pattern for testing the activities and fragments(mostly UI testing), also what we'll use, UI automator or espresso?

s-ayush2903 avatar Mar 09 '21 22:03 s-ayush2903

try something like this to test the QuestionnaireFragment

jingtang10 avatar Mar 10 '21 00:03 jingtang10

I'll take up this issue once it is clear/finalized what to use.

s-ayush2903 avatar Mar 10 '21 23:03 s-ayush2903

oops sorry i forgot to add this link: https://developer.android.com/guide/fragments/test

jingtang10 avatar Mar 11 '21 10:03 jingtang10

@s-ayush2903 I noticed you are working on #186 . Are you working on this as well or can I take it up?

epicadk avatar Mar 15 '21 13:03 epicadk

Yeah, I'm working on this too, there are so many branches now, I'll claim less issues now onwards 🥴

s-ayush2903 avatar Mar 15 '21 14:03 s-ayush2903

@jingtang10 The spelling of Questionnaire in the issue title is wrong :laughing: , change it before someone opens a PR for it 😝

s-ayush2903 avatar Mar 20 '21 09:03 s-ayush2903

@jingtang10 The spelling of Questionnaire in the issue title is wrong 😆 , change it before someone opens a PR for it 😝

😅

epicadk avatar Mar 20 '21 09:03 epicadk

I didn't intend it specifically for someone, just had in my head that there were few PRs related to it :sweat_smile:. Apologies if it made you feel uneasy :disappointed:.

s-ayush2903 avatar Mar 20 '21 10:03 s-ayush2903

I didn't intend it specifically for someone, just had in my head that there were few PRs related to it 😅. Apologies if it made you feel uneasy 😞.

No relax 😂.

epicadk avatar Mar 20 '21 13:03 epicadk

@s-ayush2903 I've updated the title of this issue - the QuestionnaireFragment in question is the one in the datacapture module rather than the datacapturegallery module. Sorry if this wasn't clear.

jingtang10 avatar Mar 22 '21 16:03 jingtang10

Thanks for info! Then what to do with the linked PR, Probably create an issue that targets the test it proposes, thoughts?

s-ayush2903 avatar Mar 22 '21 17:03 s-ayush2903

Thanks @s-ayush2903! I don't think testing the reference (gallery) application is a priority for us. In fact, I would go as far as saying it probably is a distraction. So I really would rather not work on this for now. Can you please close the linked PR and we can revisit if this becomes a priority? Thanks

jingtang10 avatar Mar 24 '21 00:03 jingtang10

@s-ayush2903 please comment on if you want to work on this? and unassign if appropriate.

jingtang10 avatar May 11 '21 09:05 jingtang10

As mentioned previously in the channel I'm not able get the instrumentation tests running on my machine for libs, so I won't be able to work on any related issues.

s-ayush2903 avatar May 11 '21 14:05 s-ayush2903

As mentioned previously in the channel I'm not able get the instrumentation tests running on my machine for libs, so I won't be able to work on any related issues.

++ I can't get them working on my device either.

epicadk avatar May 12 '21 10:05 epicadk

As mentioned previously in the channel I'm not able get the instrumentation tests running on my machine for libs, so I won't be able to work on any related issues.

What I found on my machine is that I have to right click the folder containing the instrumentation tests and select run... Not sure if this helps you.

jingtang10 avatar May 12 '21 11:05 jingtang10

As mentioned previously in the channel I'm not able get the instrumentation tests running on my machine for libs, so I won't be able to work on any related issues.

What I found on my machine is that I have to right click the folder containing the instrumentation tests and select run... Not sure if this helps you.

Thanks this works. Any idea why this happens?

epicadk avatar May 12 '21 13:05 epicadk

As mentioned previously in the channel I'm not able get the instrumentation tests running on my machine for libs, so I won't be able to work on any related issues.

What I found on my machine is that I have to right click the folder containing the instrumentation tests and select run... Not sure if this helps you.

Thanks this works. Any idea why this happens?

I'm not sure sorry. @deepankarb @yigit @florina-muntenescu @kevinmost not sure if anyone else knows why this is happening and if this is a bug worth filing to android studio.

jingtang10 avatar May 14 '21 08:05 jingtang10

Thanks @s-ayush2903! I don't think testing the reference (gallery) application is a priority for us. In fact, I would go as far as saying it probably is a distraction. So I really would rather not work on this for now. Can you please close the linked PR and we can revisit if this becomes a priority? Thanks

hi @jingtang10 is this being revisited now? i saw it in-progress here : https://github.com/google/android-fhir/projects/1#column-12632674 can I work on this?

Ana2k avatar Jun 15 '21 20:06 Ana2k

Just cleaning things up. Closing this as QuesitonnaireFragmentTest exists

omarismail94 avatar Aug 21 '23 09:08 omarismail94