android-fhir
android-fhir copied to clipboard
Flyover text added for open choice view
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1516
Description
- added support for flyover text in in open choice view in SDC library
- Updated json for open choice component with flyover extension
- Updated json for Modal component with flyover extension
Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
- [x] I have read and acknowledged the Code of conduct.
- [x] I have read the Contributing page.
- [x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
- [x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
- [x] I have run
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project. - [x] I have run
./gradlew check
and./gradlew connectedCheck
to test my changes locally. - [x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).
@PallaviGanorkar
Can you please also attach screenshot for Modal component
with flyover text?
@PallaviGanorkar Can you please also attach screenshot for
Modal component
with flyover text?
Done
Codecov Report
Merging #1625 (60593bb) into master (c4cea20) will increase coverage by
0.31%
. The diff coverage is92.85%
.
:exclamation: Current head 60593bb differs from pull request most recent head eb2b2b9. Consider uploading reports for the commit eb2b2b9 to get more accurate results
@@ Coverage Diff @@
## master #1625 +/- ##
============================================
+ Coverage 32.80% 33.12% +0.31%
Complexity 316 316
============================================
Files 151 151
Lines 5170 5166 -4
Branches 928 926 -2
============================================
+ Hits 1696 1711 +15
+ Misses 3234 3200 -34
- Partials 240 255 +15
Impacted Files | Coverage Δ | |
---|---|---|
.../QuestionnaireItemDialogSelectViewHolderFactory.kt | 76.47% <92.85%> (+0.18%) |
:arrow_up: |
.../views/QuestionnaireItemSliderViewHolderFactory.kt | 0.00% <0.00%> (ø) |
|
...hir/datacapture/MoreQuestionnaireItemComponents.kt | 22.97% <0.00%> (+8.03%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.