android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

setup benchmark module

Open epicadk opened this issue 3 years ago • 6 comments

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #825

Description Clear and concise code change description.

Setup benchmark module for benchmarking fhir engine operations.

Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

nil

Type Choose one: Feature Screenshots (if applicable)

Checklist

  • [x] I have read and acknowledged the Code of conduct
  • [x] I have read How to Contribute
  • [x] I have read the Developer's guide
  • [x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • [ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • [x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • [x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • [x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

epicadk avatar May 23 '22 17:05 epicadk

Codecov Report

Merging #1414 (c23c50e) into master (f2f2a8d) will decrease coverage by 0.03%. The diff coverage is n/a.

:exclamation: Current head c23c50e differs from pull request most recent head 077e8a0. Consider uploading reports for the commit 077e8a0 to get more accurate results

@@             Coverage Diff              @@
##             master    #1414      +/-   ##
============================================
- Coverage     85.72%   85.68%   -0.04%     
+ Complexity      716      712       -4     
============================================
  Files           149      149              
  Lines         10760    10761       +1     
  Branches        858      861       +3     
============================================
- Hits           9224     9221       -3     
  Misses         1095     1095              
- Partials        441      445       +4     
Impacted Files Coverage Δ
...droid/fhir/datacapture/QuestionnaireItemAdapter.kt 56.94% <0.00%> (-4.17%) :arrow_down:
...n/java/com/google/android/fhir/sync/SyncJobImpl.kt 59.45% <0.00%> (-2.71%) :arrow_down:
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 89.42% <0.00%> (-0.97%) :arrow_down:
...android/fhir/datacapture/mapping/ResourceMapper.kt 85.50% <0.00%> (ø)
...hir/datacapture/MoreQuestionnaireItemComponents.kt 82.60% <0.00%> (ø)
...android/fhir/datacapture/QuestionnaireViewModel.kt 78.30% <0.00%> (+0.11%) :arrow_up:
...uestionnaireItemDateTimePickerViewHolderFactory.kt 68.30% <0.00%> (+0.70%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c08192e...077e8a0. Read the comment docs.

codecov[bot] avatar May 23 '22 18:05 codecov[bot]

@epicadk thanks for raising this. is this a replacement of #822? If so can we close that PR?

jingtang10 avatar May 24 '22 13:05 jingtang10

@epicadk thanks for raising this. is this a replacement of #822? If so can we close that PR?

Yup it's a replacement.

epicadk avatar May 26 '22 17:05 epicadk

The benchmark is up and running. Just need to copy the results now.

epicadk avatar May 28 '22 06:05 epicadk

results can be found in build.zip\microbenchmark\build\outputs\androidTest-results\connected\test(AVD) - 11

epicadk avatar May 28 '22 13:05 epicadk

The next step would be to run this using firebase testlab.

epicadk avatar May 28 '22 13:05 epicadk

closing this as #1489 has been merged.

thanks @epicadk for the work!

jingtang10 avatar Dec 02 '22 17:12 jingtang10