android-emulator-container-scripts icon indicating copy to clipboard operation
android-emulator-container-scripts copied to clipboard

Support configurable emulator screen resolution

Open jnhyperion opened this issue 4 years ago • 3 comments

Added emulator screen resolution configuration options in interactive mode.

image

jnhyperion avatar Dec 18 '20 07:12 jnhyperion

  • Would you mind moving the UI pieces to emu_downloads_menu.py? OK.
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:

  1. user could have some requests of customized devices, they have various width/height/dpi, we can not list all the hardware profile
  2. Pixel2 is hard coded in many code pieces, make it a variable will have many modifications

What do you think?

jnhyperion avatar Dec 23 '20 03:12 jnhyperion

  • Would you mind moving the UI pieces to emu_downloads_menu.py? OK.
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:

  1. user could have some requests of customized devices, they have various width/height/dpi, we can not list all the hardware profile
  2. Pixel2 is hard coded in many code pieces, make it a variable will have many modifications

What do you think?

You are absolutely right. I should have prefixed it with would you like us to make those changes (different device profiles)

pokowaka avatar Dec 23 '20 04:12 pokowaka

@pokowaka sure, it would be great.

jnhyperion avatar Dec 23 '20 05:12 jnhyperion