android-cuttlefish icon indicating copy to clipboard operation
android-cuttlefish copied to clipboard

Add options to control virtio-media

Open changyeon-jo opened this issue 10 months ago • 2 comments

Implement two options to control two crosvm's command line options below:

  • --crosvm_simple-media-device
  • --crosvm_v4l2-proxy=

changyeon-jo avatar Mar 09 '25 04:03 changyeon-jo

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 09 '25 04:03 google-cla[bot]

Please kindly review changes to be able to set two new crosvm flags from a configuration JSON file.

changyeon-jo avatar Mar 09 '25 04:03 changyeon-jo

@changyeon-jo Will you rebase the Add options to control virtio-media commit on top of our main branch and get rid of the merge commits? We have the "Require linear history" setting turned on for this repository and I believe attempting to complete the PR as is will be rejected by the Github UI.

cjreynol avatar Apr 18 '25 18:04 cjreynol

@cjreynol, thanks for letting me know about the policy. I'll update this PR with a clean history soon.

changyeon-jo avatar Apr 18 '25 20:04 changyeon-jo

@cjreynol, I've updated this PR as you requested. Please kindly check and let me know if you have any questions. Thanks!

changyeon-jo avatar Apr 18 '25 21:04 changyeon-jo

Thanks for taking care of that!

I am looking into the failed kokoro check. Running those tests manually succeeded and we have an issue with the test script collecting logs, so I will follow up once I can recreate the failure or can get some logs from the runner.

cjreynol avatar Apr 22 '25 01:04 cjreynol

@changyeon-jo

Triggered another kokoro run in case the previous failure was due to flakiness. If the check fails again would you please:

  • wait until #1069 merges
  • rebase on main again so those changes are included

That PR fixes the log collection for the kokoro check, which will allow me to debug the failure.

cjreynol avatar Apr 23 '25 00:04 cjreynol