android-classyshark icon indicating copy to clipboard operation
android-classyshark copied to clipboard

Can't Examine Brave Browser App

Open busnbike opened this issue 1 year ago • 2 comments

Classyshark crashes when I try to see if Brave Browser uses trackers.

busnbike avatar Dec 07 '23 22:12 busnbike

  您好,您发送的邮件我已收到,谢谢。

yijigu7745 avatar Dec 07 '23 22:12 yijigu7745

I looked into the classy source code and tested the problematic APK. I found at least two issues:

  • The binary AndroidManifest is missing a doc end tag (0x0101); the last tag is </manifest>. Fortunately, this is a straightforward fix, and it might be beneficial to consider using a non-custom XML parser.
  • Classy uses a really old dex parsing library, org.ow2.asmdex. It's dead; there have been no changes in the last 10 years. The library supports the dex file format v35, the most recent one being v39. You can expect more issues related to this. I didn't go much deeper with my analysis.

Sorry for kind of necro-posting, but I believe it may be useful for someone.

bholota avatar Jun 07 '24 09:06 bholota