adk-python icon indicating copy to clipboard operation
adk-python copied to clipboard

fix(oauth): add client id to token exchange

Open davidkl97 opened this issue 4 months ago • 5 comments

fixes #2806 add client id to token request, adhering to RFC 6749

davidkl97 avatar Aug 31 '25 17:08 davidkl97

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 31 '25 17:08 google-cla[bot]

Response from ADK Triaging Agent

Hello @davidkl97, thank you for creating this PR!

This PR is a bug fix, could you please associate the github issue with this PR? If there is no existing issue, could you please create one?

In addition, could you please provide logs or screenshot after the fix is applied?

This information will help reviewers to review your PR more efficiently. Thanks!

adk-bot avatar Aug 31 '25 17:08 adk-bot

Hey @Jacksunwei , can you review this please?

davidkl97 avatar Sep 16 '25 15:09 davidkl97

@davidkl97 Thanks for creating this PR! Have you verified it works as expected end to end?

xuanyang15 avatar Nov 06 '25 21:11 xuanyang15

Hey @xuanyang15 , yes it works as expected once client id is passed

davidkl97 avatar Nov 22 '25 05:11 davidkl97