adk-go icon indicating copy to clipboard operation
adk-go copied to clipboard

Introduce Config type for adkrest

Open Kenasvarghese opened this issue 4 weeks ago • 1 comments

This PR introduces a Config type in the adkrest package to define session, artifact, and agent dependencies.

As a follow-up to #415, adkrest should not directly depend on launcher.Config. Defining a package-local configuration type provides a clearer and more appropriate abstraction for REST integration.

Related issue: #418

Kenasvarghese avatar Dec 16 '25 17:12 Kenasvarghese

Summary of Changes

Hello @Kenasvarghese, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the configuration management within the adkrest package by introducing a dedicated Config type. This change aims to improve modularity and reduce tight coupling by ensuring the adkrest package manages its own dependencies (session, artifact, agent services) through a specific interface, rather than relying on a broader launcher.Config.

Highlights

  • New Configuration Type: Introduced a new Config type within the adkrest package to explicitly define its required dependencies, such as session, artifact, and agent services.
  • Dependency Decoupling: Decoupled the adkrest package from directly depending on launcher.Config, addressing a follow-up from issue #415.
  • Improved Abstraction: The new package-local Config type provides a clearer and more appropriate abstraction for managing dependencies specific to REST integration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 16 '25 17:12 gemini-code-assist[bot]

@Kenasvarghese can you fix adkrest example. https://github.com/google/adk-go/blob/main/examples/rest/main.go#L69

IAmSurajBobade avatar Dec 18 '25 06:12 IAmSurajBobade

Please Review @IAmSurajBobade

Kenasvarghese avatar Dec 18 '25 17:12 Kenasvarghese

/gemini review

Kenasvarghese avatar Dec 19 '25 04:12 Kenasvarghese