adk-go icon indicating copy to clipboard operation
adk-go copied to clipboard

adkrest and adka2a should introduce their own Config types

Open rakyll opened this issue 4 weeks ago • 2 comments

As a follow up to https://github.com/google/adk-go/issues/415, we should introduce a Config type in the package rather than directly using *launcher.Config. We don't have to land both changes in the same PR but the launcher package isn't the right approach.

We need a Config type in adkrest.

rakyll avatar Dec 13 '25 21:12 rakyll

@rakyll I’d like to contribute to this issue.

My plan is to introduce a Config type inside the adkrest package (for example, in handler.go) so that NewHandler can take *adkrest.Config instead of depending directly on *launcher.Config. This would decouple adkrest from launcher while still providing the necessary configuration.

Would you prefer defining the Config struct directly in handler.go, or in a separate config.go file under adkrest?

Kenasvarghese avatar Dec 15 '25 16:12 Kenasvarghese

Please review @rakyll @dpasiukevich

Kenasvarghese avatar Dec 16 '25 17:12 Kenasvarghese