session: add ErrSessionNotFound and standardize not-exists handling (Fixes #85)
Summary
- add exported session.ErrSessionNotFound sentinel for missing sessions
- standardize in-memory and database providers to wrap not-found cases with the sentinel
- update provider tests to assert errors.Is(..., session.ErrSessionNotFound)
Fixes #85
Testing
- go test ./...
References
- Branch: https://github.com/agyn-sandbox/adk-go/tree/feature/issue-85-errsessionnotfound
- Commit: https://github.com/agyn-sandbox/adk-go/commit/981277c08ede726cc9489e342feaace84bceb34a
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Summary of Changes
Hello @casey-quinn, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines error handling for missing sessions by introducing a dedicated sentinel error, session.ErrSessionNotFound. This change standardizes how both in-memory and database session services report when a session cannot be found, allowing consuming code to reliably identify and react to this specific condition. The update ensures consistency across different storage mechanisms and improves the clarity of error messages.
Highlights
- New Sentinel Error: Introduced
session.ErrSessionNotFound, an exported sentinel error for cases where a requested session does not exist. This allows for consistent error checking usingerrors.Is. - Standardized Error Handling: The in-memory and database session providers now consistently wrap 'session not found' cases with
session.ErrSessionNotFoundin theirGet,Delete, andAppendEventmethods. - Updated Tests: Provider tests have been updated to assert errors using
errors.Is(err, session.ErrSessionNotFound), ensuring the new error handling is correctly implemented and verifiable.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
/gemini review
@casey-quinn, could you please look at https://github.com/google/adk-go/pull/302#issuecomment-3538984144 ? Signing CLA is required. Thank you!