adk-go icon indicating copy to clipboard operation
adk-go copied to clipboard
Published 4 days ago • verified publisher icon google

server/web: Return an http.Handler instead of providing a SetupRouter

Open rakyll opened this issue 2 months ago • 4 comments

Go usually prefer initiating and registering http.Handler objects from packages that provide server implementations. Then, any net/http package user can directly register them as handlers. Currently we assume users relying on mux. It's probably much better to just initiate an http.Handler and allow users to register it at their server.

rakyll avatar Nov 11 '25 05:11 rakyll

Hey there @rakyll , I can solve this issue and have started working on it. Is it possible to be assigned?

Arjunmehta312 avatar Nov 11 '25 08:11 Arjunmehta312

I have submitted a PR solving this issue and signed a New Google CLA as well since it is my first contribution to a Google repository so please do review and merge if possible.

Thanks and Regards, Arjunmehta312

Arjunmehta312 avatar Nov 11 '25 08:11 Arjunmehta312

I can review, assigned PR to me once it's ready (resolve merge conflicts, etc. Thanks for contributing!

mazas-google avatar Nov 11 '25 10:11 mazas-google

I have resolved merge conflicts @mazas-google . Please do assign the issue here to me and review as well

Thanks and Regards, Arjunmehta312

Arjunmehta312 avatar Nov 11 '25 14:11 Arjunmehta312