addlicense icon indicating copy to clipboard operation
addlicense copied to clipboard

Support for adding license to files whose name has suffix ".p4"

Open jafingerhut opened this issue 8 months ago • 5 comments

Files whose names have the suffix '.p4" are typically written in the P4 programming language: https://p4.org

jafingerhut avatar Mar 10 '25 18:03 jafingerhut

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 10 '25 18:03 google-cla[bot]

@smolkaj @jonathan-dilorenzo These people working at Google work on projects that use the P4 programming language.

jafingerhut avatar Mar 10 '25 18:03 jafingerhut

Thanks for contributing to addlicense! Please sync your pull request with master; I've changed filetypes to one-per-line to make future merge conflicts less likely. Please also add a test case in the testdata/initial and testdata/expected directories.

flwyd avatar Apr 25 '25 06:04 flwyd

The error messages I see in the log for the failing "linter / lint" CI test appear to have little to do with my 1-line change, which could not have possibly by itself introduced so many linter errors.

jafingerhut avatar Apr 26 '25 02:04 jafingerhut

Please add test cases with a before and after file in the testdata directory, and add a case to TestLicenseHeader in main_test.go.

I've fixed the linter errors; another sync with the master branch might be needed to pick up the new workflow definition.

flwyd avatar Apr 26 '25 05:04 flwyd