addlicense icon indicating copy to clipboard operation
addlicense copied to clipboard

[WIP] Refactor as importable module

Open CalebAlbers opened this issue 1 year ago • 3 comments

This is largely just to test out some of the discussion points going on in #123. It is not merge-ready and should be thoroughly vetted before any API is exposed.

CalebAlbers avatar Aug 10 '22 22:08 CalebAlbers

The bigger issue with making addlicense usable as an importable module is actually getting the importable pieces out of the main package. That's going to be a much bigger lift than just moving things out of the main func. It's sort of restructuring the whole repo. And honestly more than I've probably got bandwidth to review as well right now :-\

willnorris avatar Aug 11 '22 03:08 willnorris

The bigger issue with making addlicense usable as an importable module is actually getting the importable pieces out of the main package. That's going to be a much bigger lift than just moving things out of the main func. It's sort of restructuring the whole repo. And honestly more than I've probably got bandwidth to review as well right now :-\

I totally empathize with that! Trying to maintain open source projects in your free time with competing priorities is something I know all to well 🙂

I may tentatively plan on forking the code base as it currently sits, since we'd like to use it for some internal tooling. That said, I may still put some PRs up here and there for smaller things that would be applicable to the community (e.g., support for additional file types).

CalebAlbers avatar Aug 11 '22 04:08 CalebAlbers

Sounds good. And if I do get some free cycles, I may try doing some of the refactor in a separate branch just to see what it'd be like.

willnorris avatar Aug 11 '22 05:08 willnorris