adb-sync icon indicating copy to clipboard operation
adb-sync copied to clipboard

Published 20 hours ago • verified publisher icon google

Perform filename normalization for diff

Open shirayu opened this issue 7 years ago • 2 comments

Currently a file named to ガールズ.txt is always synchronized with Mac OS which uses HFS+ file system. This is because HFS+ file performs NFD like filename normalization. ガ is U+30AC in NFC and U+30AB U+3099 in NFD.

With this PR, adb-sync performs filename NFC normalization for diff as default. With --no-file-name-normalize, it does not.

shirayu avatar Oct 28 '17 09:10 shirayu

This is tricky - I don't think we should be munging file names by default.

One idea: check if the local file system does this, and only enable it if so. Other idea: for now make it off by default.

divVerent avatar Nov 27 '18 15:11 divVerent

BTW, while at it... could also try case folding as well, to better handle Windows systems. Also as an option.

divVerent avatar Nov 28 '18 01:11 divVerent