accompanist icon indicating copy to clipboard operation
accompanist copied to clipboard

[Permissions] fix(gh-1781): check for `Denied(shouldShowRationale=false)` in `MutableMultiplePermissionsState.shouldShowRationale`

Open FelixZY opened this issue 1 year ago • 1 comments

Adding the fix I proposed in #1781

Fixes #1781


Additional complication:

I have indications that ACCESS_BACKGROUND_LOCATION may be Denied(shouldShowRationale=false) while ACCESS_FINE_LOCATION is Denied(shouldShowRationale=true). It then seems like ACCESS_BACKGROUND_LOCATION shifts to Denied(shouldShowRationale=true) once ACCESS_FINE_LOCATION is granted.

I have not yet confirmed this but something seems to be acting strange with these two. If the above description is correct, the proposed solution in this PR is insufficient (though covering an unexpected gap that exists today).

I think someone should take a closer look and disprove the above theory before merging this (that'll probably be a few months out on my end - if even then).

FelixZY avatar Jul 12 '24 19:07 FelixZY

Sorry for the slow response here, I am planning to get to this. Just trying to get the beta release out first

bentrengrove avatar Aug 19 '24 22:08 bentrengrove

Sure! It will be a day or two but I'll do so asap.

FelixZY avatar Nov 24 '24 23:11 FelixZY

@bentrengrove rebase completed :rocket:

FelixZY avatar Nov 25 '24 12:11 FelixZY

/