accompanist icon indicating copy to clipboard operation
accompanist copied to clipboard

[DrawablePainter] Fix drawable scaling (#1766)

Open PrimoDev23 opened this issue 1 year ago • 1 comments

Properly scales the canvas to match the composables size or uses the drawable size if none is set.

PrimoDev23 avatar May 16 '24 06:05 PrimoDev23

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 16 '24 06:05 google-cla[bot]

This is intentional, it is up to drawable implementations how they fill their bounds. By doing this we would be applying scale to every drawable which would not be good.

I'll close this and have a look at the issue for you and see if I can recommend an alternative

bentrengrove avatar May 23 '24 20:05 bentrengrove