accompanist icon indicating copy to clipboard operation
accompanist copied to clipboard

[System UI Controller] Deprecation and Activity.enableEdgeToEdge

Open leinardi opened this issue 2 years ago • 5 comments

I understand that, to properly deal with edge-to-edge and status/notification bar color changes we can now use the Activity.enableEdgeToEdge method, as explained here but, what is the advised migration strategy for other features that System UI Controller is providing, like SystemUiController.systemBarsBehavior or SystemUiController.isStatusBarVisible?

leinardi avatar Sep 26 '23 09:09 leinardi

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Nov 11 '23 03:11 github-actions[bot]

comment or this will be closed in 5 days

leinardi avatar Nov 13 '23 08:11 leinardi

Help

On Mon, Nov 13, 2023, 3:32 AM Roberto Leinardi @.***> wrote:

comment or this will be closed in 5 days

— Reply to this email directly, view it on GitHub https://github.com/google/accompanist/issues/1716#issuecomment-1807673579, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6VPCDS6KUSBP7BCJKMTZLTYEHLLPAVCNFSM6AAAAAA5HM56HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGY3TGNJXHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Mwhite69 avatar Nov 13 '23 23:11 Mwhite69

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Dec 29 '23 03:12 github-actions[bot]

comment or this will be closed in 5 days

leinardi avatar Jan 01 '24 12:01 leinardi

I'm having this issue too. Activity's edge-to-edge doesn't seem to have an equivalent to isNavigationBarContrastEnforced = false

Digipom avatar Feb 07 '24 17:02 Digipom

https://issuetracker.google.com/issues/324115590

Digipom avatar Feb 07 '24 17:02 Digipom

Workaround for isNavigationBarContrastEnforced: https://issuetracker.google.com/issues/324115590#comment3

Digipom avatar Feb 09 '24 18:02 Digipom

For the window flags that aren't controlled by the opinionated enableEdgeToEdge, you can read and write them directly using the relevant Window, or via the WindowInsetsControllerCompat for that Window.

For isStatusBarVisible, you should be able to use WindowInsets.areStatusBarsVisible

alexvanyo avatar Feb 09 '24 21:02 alexvanyo