acai icon indicating copy to clipboard operation
acai copied to clipboard

Replace BeforeSuite, BeforeTest, and AfterTest with JUnit BeforeClass, Before, and After annotations

Open BenEast opened this issue 6 years ago • 3 comments

Replace BeforeSuite, BeforeTest, and AfterTest with JUnit BeforeClass, Before, and After annotations.

Updated unit tests to reference the correct annotations as well. At this point I've completely removed the custom annotations. If preferred, I can make some changes to deprecate, but still support, the old annotations.

Related to issue #3

BenEast avatar Apr 17 '19 23:04 BenEast

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 17 '19 23:04 googlebot

I signed it!

BenEast avatar Apr 17 '19 23:04 BenEast

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 17 '19 23:04 googlebot