XNNPACK icon indicating copy to clipboard operation
XNNPACK copied to clipboard

Add an API to get external value shape

Open digantdesai opened this issue 1 year ago • 3 comments

  • Add a way to get the shape of the external value. Typically used to get dynamic shape of an external output value after runtime invocation.

  • Add a couple of tests,

    • Add: standard tests w/o any reshape. Also tests invalid cases.
    • SDPA: check shapes for smaller and larger outputs than subgraph creation

digantdesai avatar Feb 02 '24 03:02 digantdesai

cc @alankelly

digantdesai avatar Feb 02 '24 03:02 digantdesai

@fbarchard - can we merge this?

digantdesai avatar Feb 12 '24 21:02 digantdesai

The review is approved but requires someone with write access to merge/land the PR

fbarchard avatar Feb 15 '24 18:02 fbarchard

Our bot which handles inporting/exporting PRs to github was temporarily broken and I think this PR got mixed up somehow with this.

I have added created a new PR with the modified comment so will close this.

alankelly avatar Feb 19 '24 09:02 alankelly