GoogleSignIn-iOS
GoogleSignIn-iOS copied to clipboard
google
Manual nonce generation option
Fixes: https://github.com/google/GoogleSignIn-iOS/issues/135 Also partly fixes: https://github.com/google/GoogleSignIn-iOS/issues/28
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Fixed conflict. Confirmed that build succeeds. Could somebody please give a proper review for this? Maybe @petea ?
Will this be unblocking the progress on implementing native sign in (#5)?
Thanks!
@petea Any change merging this? Let me know if any further action required.
@toshi0383, @ch40w31 any chance someone can take a look? it's blocking https://github.com/supabase/supabase-flutter/issues/5
Please do not mention to me. I don't have permission to merge in this repository.
@ch40w31 or @mdmathias would either of you be willing to review this?
Apologies for the delay and thanks for the PR!
I added a comment to the issue with a request for a little more information. In principle, this change should be fine.
@toshi0383 would you like to address these changes? I am also happy to contribute to this PR.
@elliottetzkorn Sounds great! I’ve been busy lately. Please go ahead and take over.
Hey @elliottetzkorn, I'm on the Supabase Auth team and this fix would greatly improve the Sign in with Google experience in mobile apps while remaining as secure as the OIDC spec intends.
I would kindly ask for an expedited review.
cc @mdmathias
Hello, Is there no way to add google login in react-native IOS app until google fixes the issue..??
Hello, Is there no way to add google login in react-native IOS app until google fixes the issue..??
Asking the same!
And is there any timeline where nonce support will be available?
Hello, please be so kind and stop spamming the thread. Me (and others) subscribed to this thread to receive valuable updates, not questions such as "when is this going to happen" or "me too" - please be mindful of others and when asking a question, think about whether it really contributes something valuable to the discussion, thank you.
To answer the question: this is open source. A feature will be available, when someone manages to open a PR which is reviewed and merged by the maintainers. That someone could be you, or someone else (could be me, if someone hires me). Until then, there are no updates. So please either wait or write the code yourself. Thank you for your understanding 👍 .
Seems like custom nonce was released 3 weeks ago https://github.com/openid/AppAuth-iOS/releases/tag/1.7.0 , are we able to revisit this PR?
Hello, I'm the author of the custom nonce functionality that was merged and released in AppAuth. I'm planning to add this feature to Google sign in SDK as well.
However, I don't have a precise timeline for this. My estimate is that I will have time to do it in 2 months. If anyone wants to support me in prioritizing it, please consider sponsoring me on GH sponsors, or get in touch. Alternatively, someone else can do it before me, of course.
I will edit this comment once I start working on it, so that there's no duplication of effort.
can anyone help me adding the nonce parameter in the google sign in package . I really need to send a nonce in the parameter while signing in. I am ready to fork and make changes.
