GoogleSignIn-iOS icon indicating copy to clipboard operation
GoogleSignIn-iOS copied to clipboard

GoogleSignIn required to be signed in Xcode

Open jkichline opened this issue 3 years ago • 15 comments

This seems like a new development, but GoogleSignIn is being required to be signed. This is quite strange for a CocoaPod. This means I need to alter the Pods project and add the signing information to only the GoogleSignIn project. What is the deal with this? It's creating distribution headaches too.

jkichline avatar Mar 03 '22 14:03 jkichline

@jkichline can you tell me how and at what point you're experiencing this requirement?

petea avatar Mar 17 '22 04:03 petea

Here's a screenshot. You'll see that GoogleSignIn in the middle column is a different color than the other frameworks and requires it to be signed in order to submit it to the App Store. the other frameworks don't need this and can go unsigned. I need to go through and manually sign the frameworks and make sure I pick the correct options for iOS vs Mac Catalyst for each of my builds (debug, beta, release, distribution). While it wouldn't be too bad if I did this once, every time I "pod update", this information is lost and needs to be entered over and over again, and I need to run "pod update" every time I switch between branches in our code base which means I run the risk of having a failed upload to the App Store every time. Screen Shot 2022-03-17 at 12 57 09 PM

Here is the warning/error we get from the App Store for the Mac Catalyst version if we don't get the settings correct. This means we need to submit another build. Screen Shot 2022-03-17 at 1 02 24 PM

I guess I wonder why GoogleSignIn is any different from any other frameworks?

jkichline avatar Mar 17 '22 17:03 jkichline

xcode 14.0 beta has this problem.

cnjsyyb avatar Jun 15 '22 08:06 cnjsyyb

+1 Same problem.

noppefoxwolf avatar Jul 12 '22 08:07 noppefoxwolf

+1, same on xcode 14 beta 3

vapor-pawelw avatar Jul 14 '22 17:07 vapor-pawelw

@petea any plans here? Would be good to have this fixed unless this is some actual xcode 14 bug that Apple needs to resolve - I haven't investigated this, but it would be good to have this sorted out

vapor-pawelw avatar Jul 25 '22 20:07 vapor-pawelw

Related discussion and possible workaround at https://github.com/firebase/firebase-ios-sdk/issues/9886

paulb777 avatar Jul 25 '22 20:07 paulb777

+1

marwenmoalla avatar Sep 14 '22 10:09 marwenmoalla

+1, same on xcode 14.0

AmineNac avatar Sep 14 '22 15:09 AmineNac

Probably related to https://github.com/google/GoogleSignIn-iOS/pull/226 and #223

johnnyasantoss avatar Sep 26 '22 17:09 johnnyasantoss

I faced this problem on Xcode 14.0 too. I temporary solved it by disabling Code signing for Pod by adding these lines to bottom of Podfile

post_install do |installer|
  installer.generated_projects.each do |target|
      target.build_configurations.each do |config|
        config.build_settings['CODE_SIGNING_ALLOWED'] = "NO"
        config.build_settings['CODE_SIGNING_REQUIRED'] = "NO"
        config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = ""
      end
    end
end

vikage avatar Oct 25 '22 02:10 vikage

I faced this problem on Xcode 14.0 too. I temporary solved it by disabling Code signing for Pod by adding these lines to bottom of Podfile

post_install do |installer|
  installer.generated_projects.each do |target|
      target.build_configurations.each do |config|
        config.build_settings['CODE_SIGNING_ALLOWED'] = "NO"
        config.build_settings['CODE_SIGNING_REQUIRED'] = "NO"
        config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = ""
      end
    end
end

On my side, this kind of fixed the issue.

Kind of because I have an app that contains an internal pod (via podspec) that contains GoogleSignIn and the solution only fixed the issue on the internal pod. Supposedly I would have to include this post_install statement on the internal pod's podspec but I think this is not possible. Any idea on how to overcome this?

OS-ricardomoreirasilva avatar Nov 10 '22 11:11 OS-ricardomoreirasilva

/Users/romas/Documents/unity/xcode/yacht/Pods/Pods.xcodeproj Signing for "GoogleSignIn-GoogleSignIn" requires a development team. Select a development team in the Signing & Capabilities editor.

I can manually specify the Team ID in XCode. But it's not right for me. How can I do this automatically from Unity?

romas34 avatar Jan 31 '23 16:01 romas34

Workaround fix from Unity. I added these lines to the end of the podfile in OnPostprocessBuild() method:

plugin 'cocoapods-pod-sign' skip_pod_bundle_sign

Also I ran the command on the Mac: $ gem install cocoapods-pod-sign

romas34 avatar Feb 03 '23 08:02 romas34

Installing CocoaPods 1.12.0 resolved this issue for us.

puopg avatar Mar 31 '23 22:03 puopg