EarlGrey icon indicating copy to clipboard operation
EarlGrey copied to clipboard

Support viewForRow in grey_pickerColumnSetToValue matcher

Open MontakOleg opened this issue 3 years ago • 6 comments

Matcher grey_pickerColumnSetToValue works fine for UIPicker with delegate that implements

  • pickerView:titleForRow:forComponent OR
  • pickerView:attributedTitleForRow:forComponent

but currently does not work for pickerView:viewForRow:forComponent:reusingView:

I believe it should work with viewForRow, because GREYPickerAction works fine with it and there even test that checks it – PickerViewInteractionTest.testViewForRowDefined.

Unfortunately, I think that this test is broken: corresponding PickerViewController implements both delegate methods – pickerView:titleForRow:forComponent AND pickerView:viewForRow:forComponent:reusingView:, that why test pass.

So, I added support for viewForRow in grey_pickerColumnSetToValue matcher, its just copy-paste from GREYPickerAction and updated test code.

MontakOleg avatar Aug 13 '22 21:08 MontakOleg

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 13 '22 21:08 google-cla[bot]

Can you sign the CLA please? @AlbertWang0116 is to look into merging this in. Albert - feel free to patch and test this internally and then close this contribution once the CLA check is passed.

tirodkar avatar Aug 15 '22 04:08 tirodkar

Sure, SLA should be already signed (as mentioned in Checks section)

MontakOleg avatar Aug 15 '22 06:08 MontakOleg

@AlbertWang0116, did you have a chance to look at this?

MontakOleg avatar Nov 01 '22 20:11 MontakOleg

@tirodkar, @AlbertWang0116 hi guys, any news here?

MontakOleg avatar Apr 05 '23 11:04 MontakOleg

Will patch and let you know.

tirodkar avatar Apr 05 '23 17:04 tirodkar