tuning_playbook icon indicating copy to clipboard operation
tuning_playbook copied to clipboard

Typo: Missing parenthesis in nesterov momentum

Open dsuedholt opened this issue 2 years ago • 2 comments

FAQs -> What are the update rules for all the popular optimization algorithms? -> Nesterov

A closing parenthesis is missing in the third equation. It's currently

$$\theta_{t+1} = \theta_{t} - \eta_t( \gamma v_{t+1} + \nabla \mathcal{l}(\theta_{t})$$

and should be

$$\theta_{t+1} = \theta_{t} - \eta_t( \gamma v_{t+1} + \nabla \mathcal{l}(\theta_{t}))$$

dsuedholt avatar Jan 20 '23 11:01 dsuedholt

Hey, can I work on this typo?

JatinKumar001 avatar Jan 22 '23 11:01 JatinKumar001

Thanks for pointing this out! Please feel free to send me a pull request.

varungodbole avatar Jan 27 '23 18:01 varungodbole

I think @znado just merged the PR to fix this. Closing this issue for now.

varungodbole avatar Mar 21 '24 20:03 varungodbole