multinerf
multinerf copied to clipboard
Update pycolmap documentation from rmbrualla to trueprice.
In the documentation, it is mentioned that we can use fisheye camera model, but you probably forgot to mention that we should use another version of pycolmap
, trueprice
, because:
- rmbrualla does not support OPENCV_FISHEYE camera model
- rmbrualla's commits has been already merged to
trueprice
(-rmbrualla
is a fork oftrueprice
-) -- Tip for testers: do not forgot to update theConfig.near
if you are using a fisheye camera ;)
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
In the documentation, it is mentioned that we can use fisheye camera model, but you probably forgot to mention that we should use another version of
pycolmap
,trueprice
, because:
- rmbrualla does not support OPENCV_FISHEYE camera model
rmbrualla's commits has been already merged to
Tip for testers: do not forgot to update thetrueprice
(-rmbrualla
is a fork oftrueprice
-)Config.near
if you are using a fisheye camera ;)
@humberthardy If using OPENCV_FISHEYE, what's the value of Config.near should setting?
@hecodeit: I notice we had a kind of "sphere removal" with fisheye around the camera (like the teleporter in terminator). My pictures were not blurred, so I used a value close to 0 (0.001 if I remember well)
@hecodeit: I notice we had a kind of "sphere removal" with fisheye around the camera (like the teleporter in terminator). My pictures were not blurred, so I used a value close to 0 (0.001 if I remember well)
Thanks @humberthardy, I'll try 0.001
I notice NerfStudio most dataset use fisheye lens, and the near plan setting using 0.05, maybe try 0.05 both.