lag
lag copied to clipboard
google-research
minor fixes to requirements and to dataset paths
Hi, thanks for the github. I noticed a couple packages that were missing from the requirements - I installed in a blank python=3 conda environment. Also, lsun princeton didn't respond, So i fixed that too.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
On Thu, May 21, 2020 at 6:06 PM googlebot [email protected] wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version https://opensource.google/docs/cla/#troubleshoot).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
- The email used to register you as an authorized contributor must also be attached to your GitHub account https://github.com/settings/emails.
ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle-research%2Flag%2Fpull%2F1 for more info.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google-research/lag/pull/1#issuecomment-632422558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJYHPOWKC6TUGQI52YXTQ23RSXFZBANCNFSM4NHLUVRQ .
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
@googlebot I fixed it..
On Thu, May 21, 2020 at 6:08 PM googlebot [email protected] wrote:
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here https://cla.developers.google.com/ to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle-research%2Flag%2Fpull%2F1 for more info.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google-research/lag/pull/1#issuecomment-632423226, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJYHPORY2OGBWQNUZ2L275TRSXGCVANCNFSM4NHLUVRQ .
Ill see if I can remove it. I was going 500 miles an hour, and didn't think it thru. Apologies about it. and Great work. thanks
On Thu, May 21, 2020 at 9:31 PM David Berthelot [email protected] wrote:
@david-berthelot requested changes on this pull request.
- Please leave tensorflow-gpu version to the latest (1.15.2).
- libml is not a dependency, it's part of the code base, please remove it from requirements.txt
- As to the lsun path, I'd rather use the official one, I contact Princeton a few days ago, they're looking why their website is not responding. Maybe you can create an issue to discuss your workaround if others face the same problem but I'd prefer the code unchanged for this.
- Your CLA still has problems.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google-research/lag/pull/1#pullrequestreview-416641121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJYHPOXO5CKPNRUWPYLCRFDRSX5ZFANCNFSM4NHLUVRQ .