fast-soft-sort icon indicating copy to clipboard operation
fast-soft-sort copied to clipboard

typos in "PyTorch Example"

Open AxelBreuer opened this issue 1 year ago • 1 comments

Hi,

First at all, thanks a lot for sharing the implementation of your beautiful algo !

As soon I heard of it, I wanted to try it out by copy-pasting the example on your github mainpage.

I suspect that the "PyTorch Example" section in your main markdown has 2 minor typos:

  1. >>> from pytorch_ops import soft_rank, soft_sort should be replaced by >>> from fast_soft_sort.pytorch_ops import soft_rank, soft_sort

  2. >>> values = fast_soft_sort.torch.tensor([[5., 1., 2.], [2., 1., 5.]], dtype=torch.float64) should be replaced by >>> values = torch.tensor([[5., 1., 2.], [2., 1., 5.]], dtype=torch.float64)

AxelBreuer avatar Jul 15 '24 15:07 AxelBreuer

Yes, you're right. +1

BraveDistribution avatar Dec 28 '24 17:12 BraveDistribution