dex-lang
dex-lang copied to clipboard
[fix] unbreak the nix code and make it slightly nicer
Fixes
- [x]
dexbuilds - [x]
dex-cudabuilds - [x]
dextests pass - [ ]
dex-cudatests pass (see Warning, I don't have an nvidia graphics card)
Additions
- nix formatter can be run with
nix fmt - replaced old
devShellandpackageargument with<output>.<system>.default - don't build the
dexruntime in theconfigurePhasebut instead build it as a separatedrv - made a couple of things more idiomatic
Note the packages of
llvm-hs,llvm-hs-pureand thedexpackage should probably be materalized, I'll perhaps at this as a PR at a later pointat some point we should probably make the legacy nix code properly follow the flake inputs I didn't update this but as
nixpkgsis not pinned anyways, I don't think it makes sense to half-ass it.
Warning before merging this, someone with an nvidia graphics card should probably check whether this builds by running
nix build github:mangoiv/dex-lang#dex-cudaon their system with an nvidia graphics card and ld library path properly setbe aware that
dexdoes not build with currentnixpkgs-unstableasfloating-bitsis broken for a while, similarly tollvm-hs/*
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I don't have a personal google account and I won't create one; I will contribute under usual terms but if that's not possible I perhaps cannot.