dex-lang icon indicating copy to clipboard operation
dex-lang copied to clipboard

[fix] unbreak the nix code and make it slightly nicer

Open MangoIV opened this issue 2 years ago • 2 comments

Fixes

  • [x] dex builds
  • [x] dex-cuda builds
  • [x] dex tests pass
  • [ ] dex-cuda tests pass (see Warning, I don't have an nvidia graphics card)

Additions

  • nix formatter can be run with nix fmt
  • replaced old devShell and package argument with <output>.<system>.default
  • don't build the dex runtime in the configurePhase but instead build it as a separate drv
  • made a couple of things more idiomatic

Note the packages of llvm-hs, llvm-hs-pure and the dex package should probably be materalized, I'll perhaps at this as a PR at a later point

at some point we should probably make the legacy nix code properly follow the flake inputs I didn't update this but as nixpkgs is not pinned anyways, I don't think it makes sense to half-ass it.


Warning before merging this, someone with an nvidia graphics card should probably check whether this builds by running nix build github:mangoiv/dex-lang#dex-cuda on their system with an nvidia graphics card and ld library path properly set

be aware that dex does not build with current nixpkgs-unstable as floating-bits is broken for a while, similarly to llvm-hs/*

MangoIV avatar Mar 07 '23 22:03 MangoIV

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 07 '23 22:03 google-cla[bot]

I don't have a personal google account and I won't create one; I will contribute under usual terms but if that's not possible I perhaps cannot.

MangoIV avatar Mar 07 '23 22:03 MangoIV