data-driven-advection icon indicating copy to clipboard operation
data-driven-advection copied to clipboard

Remove apache-beam from dependencies to prevent Colab install error

Open JiaweiZhuang opened this issue 6 years ago • 2 comments

When installing this package in Colab via !pip install git+https://github.com/google-research/data-driven-pdes.git, I got

ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

due to the apache-beam dependency.

See this notebook for the complete install error: https://colab.research.google.com/drive/1UbKevNe8BIPExuBdiqW3ZWy58Lh6E1gk

Since the beam pipeline is rarely used in notebook anyways, I just removed the beam dependency to fix the problem.

JiaweiZhuang avatar Feb 13 '20 00:02 JiaweiZhuang

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Feb 13 '20 00:02 googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Feb 13 '20 00:02 googlebot