circuit_training icon indicating copy to clipboard operation
circuit_training copied to clipboard

Bug fix for Grouping code.

Open sakundu opened this issue 2 years ago • 1 comments

Hi, I tried to run grouping code on the synthesized netlist generated using the flow given in this GitHub repo.

I noticed grouper.py and hmetis_util.py uses gfile module to which we do not have access. So I replaced gfile with os.path.

The ariane_test.pb.txt netlist, available in the grouping/testdata directory, does not contain macro orientation. If the input netlist contains macro orientation, then the grouping.py errors out. So I have suggested one line change in the grouping.py.

I can run grouping code for synthesized netlist with the above suggested changes.

Sayak

sakundu avatar Aug 02 '22 05:08 sakundu

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 02 '22 05:08 google-cla[bot]

Thank you and sorry for the long delay. We need to make this change in our conversion script as we use gfile internally. The change is in review. I hope it will get submitted in the next couple of days. After that I will close this PR. I am sorry I could not accept your change as-is. It is correct, it just has to happen in our conversion script.

tfboyd avatar Aug 25 '22 02:08 tfboyd

Sorry this took so long. I pushed what I believe is a fix. https://github.com/google-research/circuit_training/commit/83fe7210ba9518c467a59fa0eb5cd3bd6cace551

tfboyd avatar Aug 29 '22 17:08 tfboyd