flutter-plugin
flutter-plugin copied to clipboard
google-pay
Proposal to allow passing json string configuration to pay buttons
One proposal that allows the GooglePayButton, ApplePayButton, and PayButton to accept a string which can either be the payment configuration or the payment configuration file.
#7
Hi @adxzhang1, thank you for taking a stab at this one.
I think it'd be clearer to have two different properties that clearly reflect the expectation to receive an asset or a JSON string respectively. This allows us to use clear rules to differentiate the two, instead of arbitrary conditions (eg.: a file with JSON contents many not necessarily need to include the .json extension).
I'd suggest we add a separate property (eg.: paymentConfigurationString) and control with assertions that only one of them is set at init time.
What do you think?
Hi @adxzhang1, thank you for taking a stab at this one.
I think it'd be clearer to have two different properties that clearly reflect the expectation to receive an asset or a JSON string respectively. This allows us to use clear rules to differentiate the two, instead of arbitrary conditions (eg.: a file with JSON contents many not necessarily need to include the
.jsonextension).I'd suggest we add a separate property (eg.:
paymentConfigurationString) and control with assertions that only one of them is set at init time.What do you think?
Hi @JlUgia, I totally agree, that would be much better!
Hi @adxzhang1, would you be willing to adapt your PR based on the conclusion above? I've re-read the change, and we'll only need to make adjustments to the naming. I can take it over otherwise.
oh need this feature to use dynamic configuration instead of static json asset ! all check passed
Hi, what about this PR ? possible to merge it ? Thanks for the great work btw ;)
